Skip to content

ink 4.4.x breaks text input tests #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ohana54 opened this issue Sep 11, 2023 · 1 comment
Closed

ink 4.4.x breaks text input tests #627

ohana54 opened this issue Sep 11, 2023 · 1 comment

Comments

@ohana54
Copy link

ohana54 commented Sep 11, 2023

Hi,

We have failing tests after upgrading to the latest version (currently 4.4.1).
The tests use ink-text-input, and break due to the user input not being accepted/rendered.

I went to the ink-text-input repo, upgraded ink there, and saw its tests break as well.
Note I did patch ink-testing-library with the missing ref/unref methods, it breaks on expecting the user input to be rendered but it isn't.

I guess it's related to the testkit emitting a data event, but in ink you switched to readable?

@vadimdemedes
Copy link
Owner

Duplicate of #625.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants