-
-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of @alcalzone/ansi-tokenize
is a breaking change as it only supports Node 16+
#617
Comments
@newhouse Thanks for reporting this! @AlCalzone Would you be open to reverting AlCalzone/ansi-tokenize@621b28e? Was there a particular reason why Node.js v14.x support was dropped? I checked |
I'll check it out. Shouldn't be a big deal supporting node 14. |
v0.1.2 should be out in a minute or two and requires node |
Thank you @AlCalzone I can confirm that my projects and example builds are working again on Node 14 when For most situations, their setups will probably just work already...but for things to be predictably correct, it's probably a good idea to bump the dependency and then publish a new patch version with that new version. I've created a PR for this repo that bumps the min version for I think all that's left is for that to be merged, then a patch release of this by @vadimdemedes |
Thanks guys! New release is out → https://github.com/vadimdemedes/ink/releases/tag/v4.3.1. |
Hello and thank you for this library! I recently came across a problem, however.
It looks like a few weeks ago
@alcalzone/ansi-tokenize
was added to this package.The problem is that while this package supports Node 14, unfortunately
@alcalzone/ansi-tokenize
does not.For fresh installations of things that have
ink
as a dependency and there is no "old" lock file around, this might cause an error during yarn/npm install on Node 14.Here is an example of it happening for my package that I maintain: https://github.com/anvilco/spectaql/actions/runs/5766329255/job/15634072138?pr=860
And here is a screenshot of it happening when I add
ink
as a dependency to a clean Node 14 project that did not previously haveink
in the lock file:There are a bunch of directions you can go, but a few that come to mind are:
@alcalzone/ansi-tokenize
to include Node 14...if it will support it, then once it's published update the min version of it here and publish.ink
that now requires a higher node versionI hope that option 1 or 2 are chosen...but either way, something should be changed here because your
engines
specification is no longer correct.@vadimdemedes @AlCalzone
The text was updated successfully, but these errors were encountered: