Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spec.filter.limit > 20 #1

Open
3 tasks
vadasambar opened this issue May 24, 2022 · 0 comments
Open
3 tasks

Support spec.filter.limit > 20 #1

vadasambar opened this issue May 24, 2022 · 0 comments

Comments

@vadasambar
Copy link
Owner

Problem

  • As of now, spec.filter.limit > 20 cannot be specified. You will get a validation error. This is to prevent the controller from processing too deep i.e., making too many requests to fill the the 20 articles which match the filter. This is because, it'd take time and lead to a lot of requests to the api.

Solutions

  • We can't really prevent the load on the API right now but we might be able to reduce the time using goroutines

TODO

  • Evaluate goroutines for enabling spec.filter.limit > 20
  • If it seems feasible, make the change and raise a PR
  • If it doesn't comment in this issue and close it (wait for the upstream api to fix the issue i.e., give us a better api)

Definition of DONE

  • I should be able to specify spec.filter.limit = 20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant