Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: do we need logging at the domain API layer? #29

Open
saurabhnanda opened this issue Oct 15, 2016 · 1 comment
Open

Discussion: do we need logging at the domain API layer? #29

saurabhnanda opened this issue Oct 15, 2016 · 1 comment

Comments

@saurabhnanda
Copy link
Contributor

No description provided.

@jfoutz
Copy link

jfoutz commented Oct 15, 2016

the handlers run in IO. i'm pretty sure logging is just a fancier form of lift.lift.putStrLn there are some questions to answer about how to pass the file handle around, to ensure everything can log to the same file. also perhaps log rotation.

In a production system sometimes logging is necessary. For example, access logs for advertising tracking. In general, if the logs should be automatically be processed for reporting, or whatever they're needed for.

If there's something you specifically need tracked, can't that just be put in the database directly?

I understand putStrLn debugging, I don't think it's a good idea to leave those print statements in production, because it'll fill up disks with not much use.

I see the value in it, if others have strong feelings about it, but i vote no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants