Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request / response logging #11

Open
saurabhnanda opened this issue Oct 5, 2016 · 1 comment
Open

Request / response logging #11

saurabhnanda opened this issue Oct 5, 2016 · 1 comment

Comments

@saurabhnanda
Copy link
Contributor

  • Sensitive data in requests, like passwords, should be scrubbed.
  • This scrubbing should be easily configurable.
  • There should be an ability to change the log format and control what is being logged:
    • Whitelist of headers
    • Whitelist of cookies
    • URL params
    • Request body
    • Response body
    • Total time taken to respond, segmented by view, controller, & DB access
@sudhirvkumar
Copy link

I believe logging will also be using Show instance, so instead of deriving show, we can create our own instance for show and there we can filter the sensitive info from the show / log. If its sensitive enough then I guess we should take enough care to write a instance for show for that particular Type?

let me know if I am wrong. I will also do some searching...

I will think about the rest of the list and comment when I have some ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants