From 74cc942ebdabcd2da858773855d209b9e2ab44b5 Mon Sep 17 00:00:00 2001
From: Serhii Kulykov <iamkulykov@gmail.com>
Date: Fri, 31 Jan 2025 10:03:11 +0200
Subject: [PATCH] refactor: make selected property in ListMixin use sync: true
 (#8594)

---
 packages/a11y-base/src/list-mixin.js        | 1 +
 packages/a11y-base/test/list-mixin.test.js  | 2 --
 packages/select/test/select-lit.test.js     | 2 ++
 packages/select/test/select-polymer.test.js | 2 ++
 packages/select/test/select.common.js       | 2 --
 5 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/packages/a11y-base/src/list-mixin.js b/packages/a11y-base/src/list-mixin.js
index 365ec4d1268..61c66449cad 100644
--- a/packages/a11y-base/src/list-mixin.js
+++ b/packages/a11y-base/src/list-mixin.js
@@ -40,6 +40,7 @@ export const ListMixin = (superClass) =>
           type: Number,
           reflectToAttribute: true,
           notify: true,
+          sync: true,
         },
 
         /**
diff --git a/packages/a11y-base/test/list-mixin.test.js b/packages/a11y-base/test/list-mixin.test.js
index da3ba0f6b8a..fe0214a98f0 100644
--- a/packages/a11y-base/test/list-mixin.test.js
+++ b/packages/a11y-base/test/list-mixin.test.js
@@ -774,7 +774,6 @@ const runTests = (defineHelper, baseMixin) => {
 
     it('should reset previously selected item when listbox and items are disabled', async () => {
       list.selected = 3;
-      await nextUpdate(list);
       expect(items[3].selected).to.be.true;
 
       list.disabled = true;
@@ -788,7 +787,6 @@ const runTests = (defineHelper, baseMixin) => {
 
     it('should restore previously selected item when listbox becomes re-enabled', async () => {
       list.selected = 3;
-      await nextUpdate(list);
 
       list.disabled = true;
       items.forEach((item) => {
diff --git a/packages/select/test/select-lit.test.js b/packages/select/test/select-lit.test.js
index 67fed387a18..c9e691ba3e8 100644
--- a/packages/select/test/select-lit.test.js
+++ b/packages/select/test/select-lit.test.js
@@ -1,3 +1,5 @@
+import '@vaadin/item/vaadin-lit-item.js';
+import '@vaadin/list-box/vaadin-lit-list-box.js';
 import './not-animated-styles.js';
 import '../src/vaadin-lit-select.js';
 import './select.common.js';
diff --git a/packages/select/test/select-polymer.test.js b/packages/select/test/select-polymer.test.js
index e1e11b717ce..15f155cfddb 100644
--- a/packages/select/test/select-polymer.test.js
+++ b/packages/select/test/select-polymer.test.js
@@ -1,3 +1,5 @@
+import '@vaadin/item/vaadin-item.js';
+import '@vaadin/list-box/vaadin-list-box.js';
 import './not-animated-styles.js';
 import '../src/vaadin-select.js';
 import './select.common.js';
diff --git a/packages/select/test/select.common.js b/packages/select/test/select.common.js
index bdf2065b060..8ed915801e7 100644
--- a/packages/select/test/select.common.js
+++ b/packages/select/test/select.common.js
@@ -14,8 +14,6 @@ import {
   tab,
 } from '@vaadin/testing-helpers';
 import sinon from 'sinon';
-import '@vaadin/item/vaadin-item.js';
-import '@vaadin/list-box/vaadin-list-box.js';
 import { html, render } from 'lit';
 
 describe('vaadin-select', () => {