Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Valo to Lumo #158

Closed
23 tasks done
tomivirkki opened this issue Jan 9, 2018 · 5 comments
Closed
23 tasks done

Rename Valo to Lumo #158

tomivirkki opened this issue Jan 9, 2018 · 5 comments
Assignees

Comments

@tomivirkki
Copy link
Member

tomivirkki commented Jan 9, 2018

Change all mentions of Valo to Lumo. Make sure letter casing matches. Make sure theme/valo folder has been renamed. Depend on vaadin/vaadin-lumo-styles#^1.0.0 in elements

  • vaadin-lumo-styles (make public and release 1.0.0-alpha1)
  • vaadin-button
  • vaadin-checkbox
  • vaadin-combo-box
  • vaadin-context-menu
  • vaadin-core-elements
  • vaadin-date-picker
  • vaadin-dialog
  • vaadin-dropdown-menu
  • vaadin-element-skeleton
  • vaadin-form-layout
  • vaadin-grid
  • vaadin-item
  • vaadin-list-box
  • vaadin-notification
  • vaadin-ordered-layout
  • vaadin-overlay
  • vaadin-progress-bar
  • vaadin-radio-button
  • vaadin-split-layout
  • vaadin-tabs
  • vaadin-text-field
  • vaadin-upload
@jouni
Copy link
Member

jouni commented Jan 9, 2018

I can take care of deprecating the vaadin-valo-styles package and repo (adding a console warning for users to migrate to vaadin-lumo-styles).

@fasihrana
Copy link

fasihrana commented Jan 9, 2018

Will this take care of the Google Chrome Stylesheets HTML Imports Warning?

[Deprecation] Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M65, around March 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.

@tomivirkki
Copy link
Member Author

@fasihrana Not this particular change, but we're planning on fixing the warning issue during the ongoing alpha period.

@jouni
Copy link
Member

jouni commented Jan 10, 2018

@fasihrana see Polymer/polymer#5017 for more info.

Basically, the console warning is a false positive, the styling will still work. But with the small update, it should be possible to also avoid the console warning.

@jouni
Copy link
Member

jouni commented Jan 11, 2018

@tomivirkki could you add tasks for unregistering vaadin-valo-theme from Bower and registering vaadin-lumo-styles.

Update: I drafted the deprecation message for the previous package, and stated that the package and repo would be removed “after March 2018”. Does that sound alright?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants