Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

injected #619

Closed
wants to merge 1 commit into from
Closed

injected #619

wants to merge 1 commit into from

Conversation

AliKaraman
Copy link

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 22 issues

  • CRITICAL 2 critical
  • MAJOR 3 major
  • MINOR 17 minor

Top 10 issues

  1. CRITICAL MasterDetailView.java#L62: Make "samplePerson" transient or serializable. rule
  2. CRITICAL MasterDetailView.java#L64: Make "samplePersonService" transient or serializable. rule
  3. MAJOR DataGenerator.java#L19: Reduce this lambda expression number of lines from 22 to at most 20. rule
  4. MAJOR MainView.java#L67: This block of commented-out lines of code should be removed. rule
  5. MAJOR MasterDetailView.java#L128: Either log or rethrow this exception. rule
  6. MINOR MainView.java#L8: Remove this unused import 'com.vaadin.flow.component.charts.model.Navigator'. rule
  7. MINOR MainView.java#L10: Remove this unused import 'com.vaadin.flow.component.html.Div'. rule
  8. MINOR MasterDetailView.java#L38: Remove this use of "Uses"; it is deprecated. rule
  9. MINOR MasterDetailView.java#L44: Make this final field static too. rule
  10. MINOR MasterDetailView.java#L44: Rename this field "SAMPLEPERSON_ID" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule

@AliKaraman AliKaraman closed this Oct 2, 2021
@AliKaraman
Copy link
Author

by accident

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants