Skip to content

Commit 6d0b03b

Browse files
authored
fix: mark headerRenderer as unsupported for GridSortColumn (#160)
1 parent 4be5956 commit 6d0b03b

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

src/GridSortColumn.tsx

+4-10
Original file line numberDiff line numberDiff line change
@@ -11,33 +11,27 @@ import { useSimpleRenderer } from './renderers/useSimpleRenderer.js';
1111

1212
export * from './generated/GridSortColumn.js';
1313

14+
/*
15+
* The `headerRenderer` is not allowed for `vaadin-grid-sort-column`.
16+
*/
1417
export type GridSortColumnProps<TItem> = Partial<
1518
Omit<_GridSortColumnProps<TItem>, 'children' | 'footerRenderer' | 'headerRenderer' | 'renderer'>
1619
> &
1720
Readonly<{
1821
children?: ComponentType<GridBodyReactRendererProps<TItem>> | null;
1922
footerRenderer?: ComponentType<GridEdgeReactRendererProps<TItem>> | null;
20-
headerRenderer?: ComponentType<GridEdgeReactRendererProps<TItem>> | null;
2123
renderer?: ComponentType<GridBodyReactRendererProps<TItem>> | null;
2224
}>;
2325

2426
function GridSortColumn<TItem = GridDefaultItem>(
2527
props: GridSortColumnProps<TItem>,
2628
ref: ForwardedRef<GridSortColumnElement<TItem>>,
2729
): ReactElement | null {
28-
const [headerPortals, headerRenderer] = useSimpleRenderer(props.headerRenderer);
2930
const [footerPortals, footerRenderer] = useSimpleRenderer(props.footerRenderer);
3031
const [bodyPortals, bodyRenderer] = useModelRenderer(props.renderer ?? props.children);
3132

3233
return (
33-
<_GridSortColumn<TItem>
34-
{...props}
35-
footerRenderer={footerRenderer}
36-
headerRenderer={headerRenderer}
37-
ref={ref}
38-
renderer={bodyRenderer}
39-
>
40-
{headerPortals}
34+
<_GridSortColumn<TItem> {...props} footerRenderer={footerRenderer} ref={ref} renderer={bodyRenderer}>
4135
{footerPortals}
4236
{bodyPortals}
4337
</_GridSortColumn>

test/Grid.spec.tsx

+1-3
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,7 @@ describe('Grid', () => {
169169
it('should render correctly', async () => {
170170
render(
171171
<Grid<Item> items={items}>
172-
<GridSortColumn<Item> headerRenderer={DefaultHeaderRenderer} footerRenderer={DefaultFooterRenderer}>
173-
{DefaultBodyRenderer}
174-
</GridSortColumn>
172+
<GridSortColumn<Item> footerRenderer={DefaultFooterRenderer}>{DefaultBodyRenderer}</GridSortColumn>
175173
</Grid>,
176174
);
177175

0 commit comments

Comments
 (0)