Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Full-stack Signals] changes to ValueSignal should be applied locally without waiting for server acceptance #2840

Open
taefi opened this issue Oct 16, 2024 · 1 comment
Labels
bug Something isn't working hilla Issues related to Hilla

Comments

@taefi
Copy link
Contributor

taefi commented Oct 16, 2024

Describe the bug

ValueSignal should support applying the changes locally without waiting for the server acceptance.

Expected-behavior

To see the changes applied to the local value without waiting for the acceptance to be received from the server. Apart from the normal way of assigning to the value property or calling the set function which does the same as direct value assignment, ValueSignal provides two more ways of setting the value: replace and update, and all of them are supposed to support this.

Reproduction

Having a subscription to ValueSignal, attempt a replace or an update on the signal, while having a breakpoint in SignalsHandler::update endpoint to make it blocked, it can be detected that the change isn't applied locally in the browser, waiting for the event to be processed on the server.

System Info

N/A

@taefi taefi added bug Something isn't working hilla Issues related to Hilla labels Oct 16, 2024
@taefi taefi assigned taefi and unassigned taefi Oct 21, 2024
@taefi
Copy link
Contributor Author

taefi commented Oct 23, 2024

According to internal discussion, this will be put on hold (or may be closed), until the latency compensation could be implemented based on the local stack of pending changes and an event log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hilla Issues related to Hilla
Projects
None yet
Development

No branches or pull requests

1 participant