Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade target to es2022 #21039

Merged
merged 10 commits into from
Feb 25, 2025
Merged

chore: Upgrade target to es2022 #21039

merged 10 commits into from
Feb 25, 2025

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Feb 24, 2025

The combination of TS target es2022 and Vite build target including safari15 keeps the output compatible with Safari 15. It also enables using all features added in es2021 and es2022.

Copy link

github-actions bot commented Feb 24, 2025

Test Results

1 169 files  ± 0  1 169 suites  ±0   1h 40m 20s ⏱️ + 10m 39s
7 777 tests + 3  7 720 ✅ + 3  57 💤 ±0  0 ❌ ±0 
8 138 runs  +39  8 072 ✅ +39  66 💤 ±0  0 ❌ ±0 

Results for commit 30f813f. ± Comparison against base commit 933bc92.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.
com.vaadin.flow.server.frontend.TaskGenerateTsConfigTest ‑ viteShouldNotDowngradeFromEs2021
com.vaadin.flow.server.frontend.TaskGenerateTsConfigTest ‑ viteShouldNotDowngradeFromNewerEsVersion
com.vaadin.flow.server.frontend.TaskGenerateTsConfigTest ‑ viteShouldUpgradeFromEs2020
com.vaadin.viteapp.BasicsIT ‑ toplevelAwaitWorks[any_Chrome_]
com.vaadin.viteapp.ProductionBasicsIT ‑ toplevelAwaitWorks[any_Chrome_]

♻️ This comment has been updated with latest results.

@Artur- Artur- changed the title chore!: Upgrade target to es2022 chore: Upgrade target to es2022 Feb 24, 2025
@Artur- Artur- requested a review from mshabarov February 25, 2025 08:25
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Feb 25, 2025
@Artur- Artur- requested a review from caalador February 25, 2025 10:04
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Feb 25, 2025
@mshabarov mshabarov enabled auto-merge (squash) February 25, 2025 12:52
@mshabarov mshabarov merged commit fe1db22 into main Feb 25, 2025
24 of 26 checks passed
@mshabarov mshabarov deleted the es2022 branch February 25, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants