Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add vite-ping subprotocol to Vite websocket proxy #20578

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: add vite-ping subprotocol to Vite websocket proxy #20578

merged 1 commit into from
Nov 29, 2024

Conversation

mcollovati
Copy link
Collaborator

Fixes #20574

@mcollovati mcollovati mentioned this pull request Nov 29, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Test Results

1 158 files  ± 0  1 158 suites  ±0   1h 27m 44s ⏱️ - 3m 33s
7 514 tests ± 0  7 461 ✅ ± 0  53 💤 ±0  0 ❌ ±0 
7 831 runs   - 38  7 769 ✅  - 37  62 💤  - 1  0 ❌ ±0 

Results for commit 7d98926. ± Comparison against base commit 5543ba0.

@MarcinVaadin
Copy link
Member

Works great, no exception anymore!

caalador
caalador approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not getting Bad subprotocol syntax: anymore in test project after this change.

@caalador caalador merged commit 1e51ebe into main Nov 29, 2024
26 checks passed
@caalador caalador deleted the issues/20574-vite-ws-ping-subprotocol branch November 29, 2024 08:33
vaadin-bot pushed a commit that referenced this pull request Nov 29, 2024
@mcollovati @vaadin-bot
fix: add vite-ping subprotocol to Vite websocket proxy (#20578)
b93760d 
Fixes #20574
vaadin-bot added a commit that referenced this pull request Nov 29, 2024
@vaadin-bot @mcollovati
fix: add vite-ping subprotocol to Vite websocket proxy (#20578) (#20580)
2ef08ca 
Fixes #20574

Co-authored-by: Marco Collovati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcinVaadin MarcinVaadin MarcinVaadin approved these changes

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.6 target/24.6 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vite proxy connection error - Bad subprotocol syntax
4 participants
@mcollovati @MarcinVaadin @caalador @vaadin-bot