Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: React Router v7 #20537

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore: React Router v7 #20537

wants to merge 4 commits into from

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Nov 22, 2024

No description provided.

@mshabarov
Copy link
Contributor

We can try opt-in the feature flag immediately, i.e. #20527, what do you think? Flow team can take over and try how validation goes.

@mshabarov
Copy link
Contributor

And I propose to target this jump to Vaadin 24.7.

Copy link

sonarcloud bot commented Nov 27, 2024

@Artur-
Copy link
Member Author

Artur- commented Nov 27, 2024

We can try opt-in the feature flag immediately

Aren't all the flags gone in v7 and automatically on?

Copy link

Test Results

1 128 files   - 30  1 128 suites   - 30   1h 27m 41s ⏱️ - 2m 47s
7 443 tests  - 70  7 371 ✅  -  89  51 💤  - 2  2 ❌ +2  19 🔥 +19 
7 764 runs   - 90  7 683 ✅  - 109  60 💤  - 2  2 ❌ +2  19 🔥 +19 

For more details on these failures and errors, see this check.

Results for commit 162c089. ± Comparison against base commit 380b15f.

This pull request removes 70 tests.
com.vaadin.flow.BackNavIT(production) ‑ backButtonWorksAndContentUpdatesAfterPageRefresh[any_Chrome_]
com.vaadin.flow.BackNavIT(production) ‑ testBackButtonAfterHistoryStateChange[any_Chrome_]
com.vaadin.flow.BackNavIT(production) ‑ validateNoAfterNavigationForReplaceState[any_Chrome_]
com.vaadin.flow.ForwardTargetIT(production) ‑ testRouterLinkSetParameterCalledOnlyOnceAfterForward[any_Chrome_]
com.vaadin.flow.ForwardTargetIT(production) ‑ testSetParameterCalledOnlyOnceAfterForward[any_Chrome_]
com.vaadin.flow.ForwardTargetIT(production) ‑ testUrlIsCorrectAfterForward[any_Chrome_]
com.vaadin.flow.NavigationIT(production) ‑ testAnchorWithQueryNavigation[any_Chrome_]
com.vaadin.flow.NavigationIT(production) ‑ testNavigatedEvent[any_Chrome_]
com.vaadin.flow.NavigationIT(production) ‑ testNavigatedForPostponeView[any_Chrome_]
com.vaadin.flow.NavigationIT(production) ‑ testNavigationBrowserHistoryBack_anchor[any_Chrome_]
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants