Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace apache-httpclient with java.net.http.HttpClient #17734

Closed
mshabarov opened this issue Sep 28, 2023 · 4 comments
Closed

Replace apache-httpclient with java.net.http.HttpClient #17734

mshabarov opened this issue Sep 28, 2023 · 4 comments
Labels
internal improvement

Comments

@mshabarov
Copy link
Contributor

Description of the bug

Replace old apache-httpclient 4.x with modern Java 11 java.net.http.HttpClient.
This should allow to get rid of the commons libraries (to be tested).

GH discussion: #17564.

Expected behavior

Minimal reproducible example

Versions

  • Vaadin / Flow version: 24.2
@mshabarov mshabarov moved this to 🅿️Parking lot - under consideration in Vaadin Flow ongoing work (Vaadin 10+) Sep 28, 2023
@mshabarov mshabarov moved this to Internal Backlog / Technical Debt in Vaadin Flow bugs & maintenance (Vaadin 10+) Sep 28, 2023
@knoobie
Copy link
Contributor

knoobie commented Sep 28, 2023

Wasn't that already done and is pending GA release 24.2? #14538

@mshabarov
Copy link
Contributor Author

You're right, I've missed this fact.
We can close this then.

@github-project-automation github-project-automation bot moved this from 🅿️Parking lot - under consideration to Done in Vaadin Flow ongoing work (Vaadin 10+) Sep 28, 2023
@github-project-automation github-project-automation bot moved this from Internal Backlog / Technical Debt to ✅ Closed in Vaadin Flow bugs & maintenance (Vaadin 10+) Sep 28, 2023
@knoobie
Copy link
Contributor

knoobie commented Sep 28, 2023

Looks like something is missing :) OSGI still has it as dependency: https://github.com/vaadin/flow/blob/main/flow-server/bnd.bnd#L6

@mshabarov
Copy link
Contributor Author

Let's see if this passes #17735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal improvement
Projects
Vaadin Flow bugs & maintenance (Vaadin 10+)
Status: ✅ Closed
Vaadin Flow ongoing work (Vaadin 10+)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knoobie @mshabarov