Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline editing explodes unless you close the editor with [esc] #3

Closed
Legioth opened this issue Dec 14, 2023 · 4 comments
Closed

Inline editing explodes unless you close the editor with [esc] #3

Legioth opened this issue Dec 14, 2023 · 4 comments

Comments

@Legioth
Copy link
Member

Legioth commented Dec 14, 2023

Seems like the inline editor is properly removed only if it's discarded using the [esc] key.

Steps to reproduce:

  1. Double click a text to enable the inline editor
  2. Type in a new text
  3. Press [enter] (or click outside the input field). Observe that the code has been updated appropriately but the input remains visible.
  4. Press [enter] again or click anywhere. Observe that the input disappears but the regular text is still not visible. The JS console contains errors about Unable to set text Error: Unable to find text node containing '' and Uncaught TypeError: Cannot read properties of null (reading 'focus')
@Artur-
Copy link
Member

Artur- commented Dec 15, 2023

Need some more instructions on how to reproduce this as it works in some/most cases

inline-edit.mov

@Legioth
Copy link
Member Author

Legioth commented Dec 15, 2023

I might have been testing with some other version: #1 (comment)

@Legioth
Copy link
Member Author

Legioth commented Dec 15, 2023

% npx @hilla/cli init my-hilla-app
% cd my-hilla-app
% grep hilla.version pom.xml | head -n1
        <hilla.version>2.5.1</hilla.version>
% mvn 

The final seconds in the recording when the text returns is after a page reload.

Screen.Recording.2023-12-15.at.15.14.45.mov

@Artur-
Copy link
Member

Artur- commented Dec 16, 2023

I see, this is a problem with the built version only where Vite events are not delivered

@Artur- Artur- closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants