You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 6, 2021. It is now read-only.
Just started thinking that why do we have this kind of event handlers (with very generic name) as protected API?
I think this can cause problems if the user/dev provides a base class that already has an event handler with similar generic name and this can also soon become a problem/conflict in our own classes.
Currently these implementations don't check for possible super method, but even if they would, I think it's somehow weird that we have these generic event name based methods as part of an abstract class that should define the API for this mixin behaviour, but these method names don't seem to be any way related to the mixin behaviour in my opinion.
While it works, having generic names like _onKeyDown and _onClick is questionable.
We need to agree on the API we use, to make sure it is convenient and extensible.
The text was updated successfully, but these errors were encountered:
From #23 (comment)
Current implementation with the dumb classes workarounds microsoft/TypeScript#17744.
While it works, having generic names like
_onKeyDown
and_onClick
is questionable.We need to agree on the API we use, to make sure it is convenient and extensible.
The text was updated successfully, but these errors were encountered: