Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All geometry components should take materials as inputs #14

Closed
bhowes-tt opened this issue Nov 16, 2014 · 1 comment
Closed

All geometry components should take materials as inputs #14

bhowes-tt opened this issue Nov 16, 2014 · 1 comment

Comments

@bhowes-tt
Copy link
Contributor

As I mentioned in #12, I've been using these components on a real project and have found one early design decision to be especially unfortunate ... during the hackathon we thought it made sense to combine meshes and materials in the collector component using typical grasshopper iteration to do the matching.

This is inconvenient when you have lists or trees of meshes where different items (or entire collections) want to be assigned different materials. It would be better if the material was an input to the geometry components. This is a closer fit to how three.js actually works: to make a geometry object, you need a mesh and a material. Objects are made of meshes and materials, and scenes are made of objects.

Rebuild all components. Make geometry components take materials as inputs, and make the collector component more general - it should just accept a data tree of geometry objects, and each one should already be assigned a material. Create grasshopper parameters to wrap around vA3C specific types like material, mesh, line, curve, etc.

@anagpuyol
Copy link
Contributor

I just did this ⏩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants