From b8acb2e4c22533ca637c214e23769c64753f9b1f Mon Sep 17 00:00:00 2001 From: Etienne Pierre-doray Date: Tue, 28 May 2024 21:47:19 +0000 Subject: [PATCH 1/2] Fix test-http-server-keepalive-req-gc --- test/parallel/test-http-server-keepalive-req-gc.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-http-server-keepalive-req-gc.js b/test/parallel/test-http-server-keepalive-req-gc.js index 0c68ebab763223..8abe27d35030a2 100644 --- a/test/parallel/test-http-server-keepalive-req-gc.js +++ b/test/parallel/test-http-server-keepalive-req-gc.js @@ -14,9 +14,10 @@ const server = createServer(common.mustCall((req, res) => { onGC(req, { ongc: common.mustCall(() => { server.close(); }) }); req.resume(); req.on('end', common.mustCall(() => { - setImmediate(() => { + setImmediate(async () => { client.end(); - global.gc(); + await gc({type:'major', execution:'async'}); + await gc({type:'major', execution:'async'}); }); })); res.end('hello world'); From d7d6b0894946ce5d608051eeecb635f50c825b75 Mon Sep 17 00:00:00 2001 From: Etienne Pierre-doray Date: Wed, 29 May 2024 02:52:58 +0000 Subject: [PATCH 2/2] Format --- test/parallel/test-http-server-keepalive-req-gc.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-http-server-keepalive-req-gc.js b/test/parallel/test-http-server-keepalive-req-gc.js index 8abe27d35030a2..93310847d670a7 100644 --- a/test/parallel/test-http-server-keepalive-req-gc.js +++ b/test/parallel/test-http-server-keepalive-req-gc.js @@ -16,8 +16,8 @@ const server = createServer(common.mustCall((req, res) => { req.on('end', common.mustCall(() => { setImmediate(async () => { client.end(); - await gc({type:'major', execution:'async'}); - await gc({type:'major', execution:'async'}); + await global.gc({ type: 'major', execution: 'async' }); + await global.gc({ type: 'major', execution: 'async' }); }); })); res.end('hello world');