Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable redirect URL #27

Open
mcallisto opened this issue Oct 21, 2013 · 3 comments
Open

Configurable redirect URL #27

mcallisto opened this issue Oct 21, 2013 · 3 comments

Comments

@mcallisto
Copy link

Lines 110 and 111 in Controller/OpauthAppController https://github.com/uzyn/cakephp-opauth/blob/master/Controller/OpauthAppController.php#L110

$completeUrl = Configure::read('Opauth._cakephp_plugin_complete_url');
if (empty($completeUrl)) $completeUrl = Router::url('/opauth-complete');

are currently useless.

Is there a way to restore the concept of a configurable URL?
I would like to redirect to a HTTPS page (from an HTTP one).

@uzyn
Copy link
Owner

uzyn commented Oct 22, 2013

You can simply set Configure::write('Opauth._cakephp_plugin_complete_url', 'https://some-domain/path/to/login') at your main CakePHP's app bootstrap.php.

@mcallisto
Copy link
Author

Hi Uzyn, thank you for your reply and above all for the good work!

But in the current code Configure::read('Opauth._cakephp_plugin_complete_url') is put in the $completeUrl variable and then that variable is not used for redirection; that is why I was saying those lines are useless.

Can you fix it?

@uzyn
Copy link
Owner

uzyn commented Oct 23, 2013

Oh yeah, thanks for the bug report. Will take a look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants