Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layering Tests No. 2 and 3 fail #232

Open
SuzanaK opened this issue Feb 14, 2016 · 1 comment
Open

Layering Tests No. 2 and 3 fail #232

SuzanaK opened this issue Feb 14, 2016 · 1 comment

Comments

@SuzanaK
Copy link

SuzanaK commented Feb 14, 2016

The layering test on orbit.bonsaijs.org contains three tests, of which the last two fail:

Test no. 2 expects that the orange box should appear below the red and blue box but the orange box appears on top of the blue and the red box.

Test no. 3 expects that the blue square appears below the red one after one second but the blue square appears immediately on top of the red square.

Tested in Chrome (48.0) and Firefox (44.0).

@esoterra
Copy link

I created a modified test that changes the layout of the squares to make the layering more apparent and fixed the layering behavior to match the spec.

Changes:

  1. Removed unecessary numbers in addChild() calls
  2. Changed calls intended to set an item to the bottom of layer from addChild(item,1) to addChild(item,0), which appears to be the primary issue with this test
  3. Shifted the third square in Test no. 1 and Test no. 2 upward to make it overlap with square 1 in order to better demonstrate layer order

Tested in Chrome (49.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants