Skip to content

Commit 74df465

Browse files
author
Diandre Sabale
committed
removed unnecessary comments
1 parent 2561615 commit 74df465

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

Experiments/Scripts/comparison_exps.jl

+4-4
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,13 @@ end
5252

5353
println("Building...")
5454

55-
# build_experiments(experiment_params)
56-
# build_experiments(max_bounds_experiment_params)
55+
build_experiments(experiment_params)
56+
build_experiments(max_bounds_experiment_params)
5757

5858
println("Estimating...")
5959

60-
# run_estimation_experiments(experiment_params; timeout=TIMEOUT_SEC)
61-
# run_estimation_experiments(max_bounds_experiment_params; timeout=TIMEOUT_SEC)
60+
run_estimation_experiments(experiment_params; timeout=TIMEOUT_SEC)
61+
run_estimation_experiments(max_bounds_experiment_params; timeout=TIMEOUT_SEC)
6262

6363
comparison_methods = ["alley", "alleyTPI", "wj", "impr", "jsub", "cs", "cset", "sumrdf", "lss"]
6464
x_order = [string(data) for data in datasets]

Experiments/graph_results.jl

-5
Original file line numberDiff line numberDiff line change
@@ -292,11 +292,6 @@ function graph_grouped_boxplot_with_comparison_methods(experiment_params_list::V
292292
query_path = query_key[2]
293293
card = query_card_and_size[1]
294294
size = query_card_and_size[2]
295-
# TODO: CURRENT ISSUE IS THAT LSS FOLLOWS DIFFERENT FORMAT, WILL HAVE TO DO A CASE SPECIFICALLY FOR HANDLING THEIR DATASET
296-
# SOMETHING LIKE IF THE ESTIMATOR IS LSS THEN DO SOMETHING ELSE....
297-
# RIGHT NOW THEY SEARCH FOR SPECIFIC QUERY/ESTIMATOR COMBOS BUT WE CAN'T DO THAT...
298-
# WILL PROBABLY HAVE TO DO A CONTINUE WHENEVER ESTIMATOR IS LSS AND THEN DO SOMETHING AFTER THE LOOP
299-
# OR MAYBE CONSIDER CHANGING THIS TO ACCESS THE FILE SEPARATELY?
300295
for estimator in estimator_types
301296
if (estimator == "lss")
302297
continue

0 commit comments

Comments
 (0)