make Uuid a newtype #268
Merged
make Uuid a newtype #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <[email protected]>
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
|
What's the gain in this? |
|
@Dylan-DPC As far as I can see there is no particular gain. However, I am preparing this for consistency as the the new adapters will be newtypes (see #256) |
Dylan-DPC-zz
approved these changes
Jun 22, 2018
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2018
268: make Uuid a newtype r=Dylan-DPC a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [ ] feature enhancement - [ ] deprecation or removal - [x] refactor # Description * Convert `Uuid` into a newtype. * Use `Uuid::from_uuid_bytes` (as the main constructor) to construct a `Uuid` where possible # Motivation We treat `Uuid` like a newtype, this makes it more obvious # Tests All tests passing # Related Issue(s) #266 Co-authored-by: Hunar Roop Kahlon <[email protected]>
Build failed |
|
Nightly builds failed due to rust-lang/rust#51699 |
|
bors: try |
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Jun 23, 2018
268: make Uuid a newtype r=Dylan-DPC a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [ ] feature enhancement - [ ] deprecation or removal - [x] refactor # Description * Convert `Uuid` into a newtype. * Use `Uuid::from_uuid_bytes` (as the main constructor) to construct a `Uuid` where possible # Motivation We treat `Uuid` like a newtype, this makes it more obvious # Tests All tests passing # Related Issue(s) #266 Co-authored-by: Hunar Roop Kahlon <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a ...
Description
Uuidinto a newtype.Uuid::from_uuid_bytes(as the main constructor) to construct aUuidwhere possibleMotivation
We treat
Uuidlike a newtype, this makes it more obviousTests
All tests passing
Related Issue(s)
#266