Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make uuid structs repr(transparent) #468

Merged
merged 5 commits into from
Sep 4, 2020
Merged

make uuid structs repr(transparent) #468

merged 5 commits into from
Sep 4, 2020

Conversation

kinggoesgaming
Copy link
Member

I'm submitting a(n) feature

Description

Make the following structs #[repr(transparent)]:

  • Uuid
  • Hyphenated
  • HyphenatedRef
  • Simple
  • SimpleRef
  • Urn
  • UrnRef

Tests

Tests should pass as is

Related Issue(s)

closes #463

@kinggoesgaming
make uuid structs repr(transparent)
04ce0fb 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming kinggoesgaming self-assigned this Mar 23, 2020
@kinggoesgaming
Copy link
Member Author

kinggoesgaming commented Sep 4, 2020 •
edited
Loading

@uuid-rs/uuid approve/merge :)

@KodrAus
Copy link
Member

KodrAus commented Sep 4, 2020

I'm on board with marking Uuid as #[repr(transparent)]. I'm not sure we need to commit to marking its display adapters as transparent though, do we? I could imagine wanting to capture some other formatting information in some of them one day, like what case to use for a - f.

@kinggoesgaming
Copy link
Member Author

I'm on board with marking Uuid as #[repr(transparent)]. I'm not sure we need to commit to marking its display adapters as transparent though, do we? I could imagine wanting to capture some other formatting information in some of them one day, like what case to use for a - f.

@KodrAus fair enough! I will remove the attribute from the adapters

@kinggoesgaming
remove repr transparent from adapters
b0d8527 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
Copy link
Member Author

@KodrAus anything else?

KodrAus
KodrAus approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@KodrAus
Copy link
Member

KodrAus commented Sep 4, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 4, 2020

Build succeeded:

@bors bors bot merged commit 1ed4ff2 into master Sep 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the the-transparency-report branch September 4, 2020 04:37
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KodrAus KodrAus KodrAus approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

Assignees

@kinggoesgaming kinggoesgaming

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make Uuid #[repr(transparent)]
2 participants
@kinggoesgaming @KodrAus