mk: tslint => eslint

Config copied from
https://github.com/yoursunny/NDNts/blob/09712390dea02f7c7bb59f7988fbdaf7bb1869f4/mk/eslintrc-js.js
https://github.com/yoursunny/NDNts/blob/09712390dea02f7c7bb59f7988fbdaf7bb1869f4/mk/eslintrc-ts.js

fixes #3

Author: yoursunny

mgmt/jrgen-spec-schema.ts

@@ -3,7 +3,6 @@
 // npx -p json-schema-to-typescript json2ts -i jrgen-spec.schema.json -o mgmt/jrgen-spec-schema.ts
 // rm jrgen-spec.schema.json
 
-/* tslint:disable */
 /**
  * This file was automatically generated by json-schema-to-typescript.
  * DO NOT MODIFY IT BY HAND. Instead, modify the source JSONSchema file,

mgmt/make-spec.ts

@@ -22,7 +22,7 @@ const spec: JrgenSpecSchema = {
   methods: {},
 };
 
-const mgmtModules: { [k: string]: string; } = {};
+const mgmtModules: { [k: string]: string } = {};
 for (const [propName, propSchema] of Object.entries(schema.properties!)) {
   const typeName = (propSchema as TJS.Definition).$ref!.replace("#/definitions/", "");
   mgmtModules[typeName] = propName;
@@ -32,7 +32,7 @@ for (const [typeName, typeSchema] of Object.entries(schema.definitions!)) {
   if (mgmtModules[typeName]) {
     const methodPrefix = mgmtModules[typeName];
     for (const [methodSuffix, methodSchema] of Object.entries((typeSchema as TJS.Definition).properties!)) {
-      spec.methods[methodPrefix + "." + methodSuffix] = {
+      spec.methods[`${methodPrefix}.${methodSuffix}`] = {
         params: (methodSchema as TJS.Definition).properties!.args,
         result: (methodSchema as TJS.Definition).properties!.reply,
         summary: "",
@@ -43,4 +43,4 @@ for (const [typeName, typeSchema] of Object.entries(schema.definitions!)) {
   }
 }
 
-process.stdout.write(jsonStringify(spec, {space: 2}));
+process.stdout.write(jsonStringify(spec, { space: 2 }));

mgmt/rpc-client.ts

@@ -35,7 +35,7 @@ export function makeMgmtClient(): RpcClient {
 
   const u = new URL(mgmtEnv);
   if (!/^tcp[46]?:$/.test(u.protocol)) {
-    throw new Error("unsupported MGMT scheme " + u.protocol);
+    throw new Error(`unsupported MGMT scheme ${u.protocol}`);
   }
 
   const jaysonClient = jayson.Client.tcp({

mk/eslintrc-js.js

@@ -0,0 +1,54 @@
+module.exports = {
+  plugins: [
+    "simple-import-sort",
+  ],
+  env: {
+    es2020: true,
+    node: true,
+  },
+  extends: [
+    "eslint:recommended",
+  ],
+  rules: {
+    "simple-import-sort/sort": "error",
+    "array-bracket-spacing": ["error", "never"],
+    "arrow-parens": "error",
+    "arrow-spacing": "error",
+    "block-spacing": "error",
+    "camelcase": "error",
+    "comma-dangle": ["error", "always-multiline"],
+    "comma-spacing": "error",
+    "comma-style": "error",
+    "computed-property-spacing": ["error", "never", { enforceForClassMembers: true }],
+    "curly": "error",
+    "dot-location": ["error", "property"],
+    "dot-notation": "error",
+    "eol-last": "error",
+    "eqeqeq": "error",
+    "func-call-spacing": "error",
+    "key-spacing": "error",
+    "keyword-spacing": "error",
+    "no-console": "warn",
+    "no-constant-condition": ["error", { checkLoops: false }],
+    "no-else-return": "error",
+    "no-empty": ["error", { allowEmptyCatch: true }],
+    "no-spaced-func": "error",
+    "no-useless-call": "error",
+    "no-var": "error",
+    "object-curly-spacing": ["error", "always"],
+    "object-shorthand": "error",
+    "prefer-arrow-callback": "error",
+    "prefer-const": ["error", { destructuring: "all" }],
+    "prefer-rest-params": "error",
+    "prefer-spread": "error",
+    "prefer-template": "error",
+    "quotes": ["error", "double", { allowTemplateLiterals: true }],
+    "radix": "error",
+    "semi": "error",
+    "semi-spacing": "error",
+    "space-before-blocks": "error",
+    "space-in-parens": "error",
+    "switch-colon-spacing": "error",
+    "template-curly-spacing": "error",
+  },
+};

mk/eslintrc-ts.js

@@ -0,0 +1,41 @@
+const path = require("path");
+const jsRc = require("./eslintrc-js");
+
+module.exports = {
+  parser: "@typescript-eslint/parser",
+  parserOptions: {
+    project: path.resolve(__dirname, "..", "tsconfig.json"),
+  },
+  plugins: [
+    "@typescript-eslint/eslint-plugin",
+    "simple-import-sort",
+  ],
+  env: {
+    node: true,
+  },
+  extends: [
+    "eslint:recommended",
+    "plugin:@typescript-eslint/eslint-recommended",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:@typescript-eslint/recommended-requiring-type-checking",
+  ],
+  rules: {
+    ...jsRc.rules,
+    "@typescript-eslint/ban-ts-ignore": "off",
+    "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/member-delimiter-style": ["error", { singleline: { delimiter: "comma" } }],
+    "@typescript-eslint/no-empty-interface": ["error", { allowSingleExtends: true }],
+    "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/no-inferrable-types": ["error", { ignoreParameters: true, ignoreProperties: true }],
+    "@typescript-eslint/no-misused-promises": ["error", { checksVoidReturn: false }],
+    "@typescript-eslint/no-namespace": "off",
+    "@typescript-eslint/no-non-null-assertion": "off",
+    "@typescript-eslint/no-unused-vars": ["warn", { args: "none" }],
+    "@typescript-eslint/no-use-before-define": "off",
+    "@typescript-eslint/require-await": "off",
+    "@typescript-eslint/unbound-method": ["error", { ignoreStatic: true }],
+    "constructor-super": "off",
+    "no-inner-declarations": "off",
+    "require-atomic-updates": "off",
+  },
+};

mk/format-code.sh

@@ -3,6 +3,7 @@ gofmt -l -w -s .
 find -name '*.h' -o -name '*.c' \
   | grep -vE 'pcg_basic|siphash-20121104|uthash|zf_log' \
   | xargs clang-format-6.0 -i -style='{BasedOnStyle: Mozilla, ReflowComments: false}'
-node_modules/.bin/tslint --fix -p .
+node_modules/.bin/eslint --ignore-path .gitignore -c mk/eslintrc-ts.js --fix **/*.ts
+node_modules/.bin/eslint --ignore-path .gitignore -c mk/eslintrc-js.js --fix **/*.js
 find . -path ./node_modules -prune -o \( -name '*.yaml' -o -name '*.yml' \) -print | xargs yamllint
 node_modules/.bin/markdownlint --ignore node_modules '**/*.md'