Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes UserFrosting#965 - Ignore files that don't end in .php #998

Merged
merged 2 commits into from
Jun 13, 2019

Conversation

xrobau
Copy link
Contributor

@xrobau xrobau commented Jun 9, 2019

This ignores any files in Migrations that do not end in .php

It causes problems when scripts, or data, or documentation is
left in the Migrations directory, and the migration task assumes
that they are PHP Classes and crashes.

Signed-Off-By: Rob Thomas [email protected]

This ignores any files in Migrations that do not end in .php.
It causes problems when scripts, or data, or documentation is
left in the Migrations directory, and the migration task assumes
that they are PHP Classes and crashes.

Signed-Off-By: Rob Thomas <[email protected]>
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #998 into hotfix will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             hotfix     #998      +/-   ##
============================================
+ Coverage     68.21%   68.22%   +<.01%     
- Complexity     2139     2140       +1     
============================================
  Files           159      159              
  Lines          7243     7244       +1     
============================================
+ Hits           4941     4942       +1     
  Misses         2302     2302
Impacted Files Coverage Δ Complexity Δ
...es/core/src/Database/Migrator/MigrationLocator.php 100% <100%> (ø) 5 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2f828...e32313e. Read the comment docs.

@lcharette lcharette merged commit a4e4b81 into userfrosting:hotfix Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants