Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When internationalizing, the lang attribute value of the Twig template is not set to follow changes. #982

Closed
ZhangChengLin opened this issue May 24, 2019 · 3 comments
Closed

When internationalizing, the lang attribute value of the Twig template is not set to follow changes. #982

ZhangChengLin opened this issue May 24, 2019 · 3 comments
Labels
core feature request Feature request internationalization Related to the localization feature
Milestone
4.4.0

Comments

@ZhangChengLin
Copy link

ZhangChengLin commented May 24, 2019 •
edited by lcharette
Loading

UserFrosting/app/sprinkles/core/templates/pages/abstract/base.html.twig

Line 5 in 07d9035

<html lang="en-US">

Please excuse me.I won't provide the corresponding code PR for Twig, so I only ask questions and hope that UserFrosting will get better.
@ZhangChengLin ZhangChengLin changed the title 国际化的时候，Twig 模板的lang属性值没有设置跟随变化 When internationalizing, the lang attribute value of the Twig template is not set to follow changes. May 24, 2019
@lcharette
Copy link
Member

This tag <html lang="en-US"> ?

@ZhangChengLin
Copy link
Author

This tag <html lang="en-US"> ?

Yes!

@lcharette lcharette added core feature request Feature request internationalization Related to the localization feature labels May 24, 2019
@lcharette lcharette added this to the 4.4.0 milestone May 24, 2019
@lcharette
Copy link
Member

Done in 0ba8ab4 for UF 4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core feature request Feature request internationalization Related to the localization feature
Projects
None yet
Milestone
4.4.0
Development

No branches or pull requests
2 participants
@lcharette @ZhangChengLin