-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to FontAwesome 5 #870
Comments
Download FA5, rename/delete and replace Change
in done :) |
Didn’t FA also changed icon names and prefix in 5? |
Actually, for a permanent fix, it should be changed in the bower file. We also need to provide support if someone wants to use the pro version (which I don't know how it works). |
The additional CSS files are supposed to add backwards compatibility. Also note that they have removed the hyphen in font-awesome file and folder names |
I have been working on upgrading to FA 5 here. FA5 removed all aliases. As long as people are aware about the change it should not be a difficult transition. Probably easiest for people to just do the update and then go through their site looking for any missing icons, then update the FA tags as needed. I'm not sure we could really make using FA 5 Pro any easier on the UserFrosting side. The user must decide between global/per-project setup and then add their authentication token.. See https://fontawesome.com/how-to-use/on-the-web/setup/using-package-managers It may be more appropriate for FA Pro to be added in a Sprinkle. |
If we can't have a config for it, I guess so. Can we load with NPM both free and pro version, or does loading both will produce errors? |
You need to add special NPM registry entry with authentication key
|
I have not really looked into the bakery much myself. If we could use a special bakery command that asked for the authentication key and then ran those two commands, I guess that might be an option. |
More the interaction between those two :
Afterward, we can have a I do have a pro license if you need someone to test a custom sprinkle ;) |
Where would be the best place to store the config setting for this? |
I'm not exactly sure how this would look. |
All password or secrets should be in
Those bundle : https://github.com/userfrosting/UserFrosting/blob/master/app/sprinkles/core/asset-bundles.json#L67-L78 |
I started working on a bakery command. Here's what I have so far |
No description provided.
The text was updated successfully, but these errors were encountered: