Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata for locale #850

Closed
lcharette opened this issue Feb 7, 2018 · 2 comments
Closed

Metadata for locale #850

lcharette opened this issue Feb 7, 2018 · 2 comments
Assignees
Labels
confirmed bug Something isn't working internationalization Related to the localization feature standards and best practices Coding guidelines
Milestone

Comments

@lcharette
Copy link
Member

lcharette commented Feb 7, 2018

See userfrosting/i18n#4

This is dumb, as it doesn't works if the default has a space somewhere : https://github.com/userfrosting/UserFrosting/blob/develop/app/sprinkles/core/src/ServicesProvider/ServicesProvider.php#L437

This is rubbish and that's not how the default works : https://github.com/userfrosting/UserFrosting/blob/develop/app/sprinkles/core/src/ServicesProvider/ServicesProvider.php#L451

And that whole thing is just messy : https://github.com/userfrosting/UserFrosting/blob/develop/app/sprinkles/core/config/default.php#L140-L159

tl;dr FU the current available config, FU the default config with it's obscure order. Locale metadata with dependencies and name FTW. An array of available locale FTW.

@lcharette lcharette added confirmed bug Something isn't working standards and best practices Coding guidelines internationalization Related to the localization feature labels Feb 7, 2018
@lcharette lcharette added this to the 4.2.0 milestone Feb 7, 2018
@lcharette lcharette self-assigned this Feb 7, 2018
@lcharette
Copy link
Member Author

So first question. How do we store locales config and where ?

In a Yaml file? In /locale/fr_FR/fr_FR.yaml or in locales/fr_FR.yaml ? In core sprinkle? A new sprinkle add a new locale / wants to replace the config they replace said file in their own locales/ folder ?

@lcharette
Copy link
Member Author

This as been implemented with new version of i18n for UF 4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug Something isn't working internationalization Related to the localization feature standards and best practices Coding guidelines
Projects
None yet
Development

No branches or pull requests

1 participant