Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Composer 2 #1117

Closed
lcharette opened this issue Nov 14, 2020 · 8 comments
Closed

Incompatible with Composer 2 #1117

lcharette opened this issue Nov 14, 2020 · 8 comments
Labels
compatibility Compatibility issue with other framework, features
Milestone

Comments

@lcharette
Copy link
Member

Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - wikimedia/composer-merge-plugin dev-master requires composer-plugin-api ^1.1 -> found composer-plugin-api[2.0.0] but it does not match the constraint.
    - wikimedia/composer-merge-plugin[v1.4.0, ..., v1.4.1] require composer-plugin-api ^1.0 -> found composer-plugin-api[2.0.0] but it does not match the constraint.
    - wikimedia/composer-merge-plugin 1.5.x-dev is an alias of wikimedia/composer-merge-plugin dev-master and thus requires it to be installed too.
    - Root composer.json requires wikimedia/composer-merge-plugin ^1.4.0 -> satisfiable by wikimedia/composer-merge-plugin[v1.4.0, v1.4.1, 1.5.x-dev (alias of dev-master)].

You are using Composer 2, which some of your plugins seem to be incompatible with. Make sure you update your plugins or report a plugin-issue to ask them to support Composer 2.

This is dependent of an issue with wikimedia/composer-merge-plugin, and can only be solved once wikimedia/composer-merge-plugin#189 (comment) is merged and released.

Other reference : wikimedia/composer-merge-plugin#184

@lcharette lcharette added the compatibility Compatibility issue with other framework, features label Nov 14, 2020
@lcharette lcharette added this to the 4.5.0 milestone Nov 14, 2020
@lcharette lcharette pinned this issue Nov 14, 2020
@lcharette lcharette modified the milestones: 4.5.0, 4.4.x Nov 14, 2020
@lcharette lcharette linked a pull request Nov 20, 2020 that will close this issue
@lcharette
Copy link
Member Author

We should be able to fix this now by upgrading wikimedia/composer-merge-plugin to this new release :
https://github.com/wikimedia/composer-merge-plugin/releases/tag/v2.0.1

@Silic0nS0ldier
Copy link
Member

And raising our minimum PHP version from 7.1 to 7.2 (as per plugin requirements). Otherwise looks to a fairly straightforward update thankfully.

@lcharette
Copy link
Member Author

We're still supporting 7.1? Might as well release 4.5 while at it. Do you have any other change / BC that requires a major bump ?

@Silic0nS0ldier
Copy link
Member

Yeah, NodeJS for ESM support. Not ready for prime time yet, but raising will let it release more easily.
Min is ^12.17.0 || >=13.2.0.

@lcharette
Copy link
Member Author

Yeah, NodeJS for ESM support. Not ready for prime time yet, but raising will let it release more easily.
Min is ^12.17.0 || >=13.2.0.

Care to push the required change to develop and/or open PR? I'll see if I can release this fix over the weekend.

@Silic0nS0ldier
Copy link
Member

Sure. I'll see about getting it up this afternoon (my time, so in around 9 hours).

@Silic0nS0ldier
Copy link
Member

I've opened #1138

@lcharette lcharette modified the milestones: 4.4.x, 4.4.5, 4.5.0 Mar 5, 2021
@lcharette
Copy link
Member Author

This issue is fixed in ab33733 on develop for 4.5.0 release.

@lcharette lcharette unpinned this issue Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility issue with other framework, features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants