Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old browserified packages are not removed #1092

Closed
Silic0nS0ldier opened this issue Apr 29, 2020 · 0 comments · Fixed by #1093
Closed

Old browserified packages are not removed #1092

Silic0nS0ldier opened this issue Apr 29, 2020 · 0 comments · Fixed by #1093
Assignees
@Silic0nS0ldier
Labels
assets Related to the assets feature confirmed bug Something isn't working
Milestone
4.4.2

Comments

@Silic0nS0ldier
Copy link
Member

This presents a major problem for people upgrading to 4.4 as the feature was fixed/properly implemented in this release.

The problem is that old files are not removed from the app/assets/browser_modules folder which is causing the older broken modules to be taking the place of the actual NPM dependencies.

Discovered at https://gist.github.com/malle-pietje/52a4797e265f83dd1dda22c96132ece8
@Silic0nS0ldier Silic0nS0ldier added confirmed bug Something isn't working assets Related to the assets feature labels Apr 29, 2020
@Silic0nS0ldier Silic0nS0ldier added this to the 4.4.2 milestone Apr 29, 2020
@Silic0nS0ldier Silic0nS0ldier self-assigned this Apr 29, 2020
@Silic0nS0ldier Silic0nS0ldier linked a pull request Apr 29, 2020 that will close this issue
Fix browser_modules folder not being deleted during install #1093
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Silic0nS0ldier Silic0nS0ldier

Labels
assets Related to the assets feature confirmed bug Something isn't working
Projects
None yet
Milestone
4.4.2
Development

Successfully merging a pull request may close this issue.

Fix browser_modules folder not being deleted during install userfrosting/UserFrosting
2 participants
@lcharette @Silic0nS0ldier