Fix direct password edit

[rwos]

Bug: editing a users password does not work, it always ends up as invalid because "the passwords don't match".

This fixes that by making the name of the password field flexible:

• 'password' on the user creation form
• 'value' on the edit password form (since that goes through admin's UserController::updateField)

this replaces #1034
see also #1030

I now see that the whole thing could've also been fixed by calling the password field "value" (and reverting the above PR), but that looks a bit weird IMHO. But let me know what you think!

[codecov]

Codecov Report

Merging #1038 into hotfix will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             hotfix   #1038      +/-   ##
===========================================
+ Coverage     66.66%   66.7%   +0.03%     
  Complexity     1931    1931              
===========================================
  Files           162     162              
  Lines          6737    6745       +8     
===========================================
+ Hits           4491    4499       +8     
  Misses         2246    2246

Impacted Files	Coverage Δ	Complexity Δ
.../sprinkles/admin/src/Controller/UserController.php	99.6% <100%> (ø)	112 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18bc0c3...5bc185b. Read the comment docs.

[amosfolz]

@rwos Have you tested to make sure this is compatible with updating existing users password?

[rwos]

@amosfolz that's exactly the thing that this fixes. But I would appreciate someone other than me checking this again with v4.3.1 (setting a manual password on user creation works, updating a user's password is broken) and this PR (both work). I'm reasonably sure this works, but I was reasonably sure in #1030 too :-)

[n0use]

My original comment said this only fixed CHANGING a password on 4.3.1 - this turned out to be my own fault, a sprinkle I had written had an old copy of the schema/requests/user/create.yaml file. When I got this updated (the offending difference was field: password vs field: value) everything password related, creating users with passwords or changing existing users passwords, works with this PR. Thanks!

I just tried this on 4.3.1 and it does fix CHANGING a users password, which is good, but I get the same "Your password and confirmation password must match." error when trying to CREATE a user with a password set.

[amosfolz]

I think this still needs some work. For example, validation messages appear not to match anymore:

[lcharette]

#1034 (comment)

The "single controller method accepting any field" thing could be phased out for password if this is too much of an issue.

[rwos]

Alright - validation should be fixed now, and it now also uses the site.password.length config everywhere (edit password + user create), as it should.

[lcharette]

So... Which one between this (#1038) and #1034 actually fix this issue?

[amosfolz]

This is the one I tested - everything worked besides the validation message. If that is fixed, this should be merged and the other closed.

[lcharette]

I've merged this, and with #1034, made other improvement in 29bfdd4. Should be good to go now.

I change the behavior of UserController::updateField. Instead of using a common value key for all fields, the key is now the field name itself.

For example, when updating flag_enable, the data should be flag_enabled => 1 instead of value => 1. So now edit-password.yaml will have the proper password value in it.

Could introduce a minor Breaking change if someone uses that class in it's own sprinkle. Will add a note in the changelog.