Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in form.fields.hidden #1033

Merged
merged 1 commit into from
Sep 14, 2019
Merged

Conversation

phillmac
Copy link
Contributor

Fix typos: missing form. in form.fields.hidden for icon and description

Noticed that these two fields were not being hidden despite including them in form.fields.hidden in the controller.

Fix typos: missing `form.`  in `form.fields.hidden` for icon and description
@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #1033 into hotfix will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             hotfix    #1033   +/-   ##
=========================================
  Coverage     66.66%   66.66%           
  Complexity     1931     1931           
=========================================
  Files           162      162           
  Lines          6737     6737           
=========================================
  Hits           4491     4491           
  Misses         2246     2246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e6711...213a4b0. Read the comment docs.

@lcharette lcharette added this to the 4.3.x milestone Sep 11, 2019
@lcharette lcharette added possible bug We suspect something isn't working confirmed bug Something isn't working and removed possible bug We suspect something isn't working labels Sep 11, 2019
@amosfolz
Copy link
Contributor

fields.hidden seems to be in a few other places as well: https://github.com/userfrosting/UserFrosting/blob/master/app/sprinkles/admin/templates/forms/role.html.twig#L35

Are we sure that wasn't intentional?

@lcharette
Copy link
Member

lcharette commented Sep 11, 2019

Unless you're in a for loop, should start with form :

'form' => [
'action' => 'api/roles',
'method' => 'POST',
'fields' => $fields,
'submit_text' => $translator->translate('CREATE'),
],

@lcharette lcharette merged commit 58e664c into userfrosting:hotfix Sep 14, 2019
@lcharette lcharette removed this from the 4.5.x milestone Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants