Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Arabic Locales #1028

Merged
merged 3 commits into from
Aug 31, 2019
Merged

Update Arabic Locales #1028

merged 3 commits into from
Aug 31, 2019

Conversation

abdullahseba
Copy link
Contributor

No description provided.

@@ -57,11 +57,11 @@
'@TRANSLATION' => 'سياسة الخصوصية',
'DESCRIPTION' => 'تحدد سياسة الخصوصية لدينا نوع المعلومات التي نجمعها منك وكيفية استخدامها.',
],
// 'SLUG' => 'Slug',
'SLUG' => 'سبيكة',
'SLUG_CONDITION' => 'Slug/الظروف',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if there is a comparable word for slug. If so, should this line be updated?

@abdullahseba
Copy link
Contributor Author

I didn't know of that word either as it happens. I was expecting a slug:
image
But the word I used means slug as in metal alloy so I could update it I guess. I'm not too sure how an actual Arab person would understand it.

@codecov
Copy link

codecov bot commented Aug 31, 2019

Codecov Report

Merging #1028 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1028   +/-   ##
=========================================
  Coverage     66.66%   66.66%           
  Complexity     1931     1931           
=========================================
  Files           162      162           
  Lines          6737     6737           
=========================================
  Hits           4491     4491           
  Misses         2246     2246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d87fd...f8eb4d7. Read the comment docs.

@amosfolz
Copy link
Contributor

I didn't know of that word either as it happens. I was expecting a slug:
image
But the word I used means slug as in metal alloy so I could update it I guess. I'm not too sure how an actual Arab person would understand it.

I'm not sure it needed to be changed, just wanted to make sure you saw that one.

Everything else looks great. Thanks for helping.

@lcharette lcharette changed the base branch from master to hotfix August 31, 2019 18:13
@lcharette lcharette merged commit 3a18cdd into userfrosting:hotfix Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants