Pageview ID shouldn't be generated from the tracker #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ID should always be server generated - so in this case from the collector. Generating it on the client and just "storing" it on the collector makes it difficult and insecure. Because of backward compability we limit the generated UUID to only 32 chars. Closes #322 Closes #312 Signed-off-by: Lukas Kämmerling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ID should always be server generated - so in this case from the collector. Generating it on the client and just "storing" it on the collector makes it difficult and insecure. Because of backward compability we limit the generated UUID to only 32 chars.
Closes #322
Closes #312
Signed-off-by: Lukas Kämmerling [email protected]