Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add heroku 1-click support #292

Closed
wants to merge 0 commits into from
Closed

add heroku 1-click support #292

wants to merge 0 commits into from

Conversation

JaneJeon
Copy link

I managed to recover #290. Basically you can remove docs/misc/Heroku.md (if you'd like) and close #279 since this button handles everything for you - no need for the complicated process!

As stated in #290, I've already had this up and running on my own Heroku account serving my own sites for some time now, so I know it works.

Here's to hoping this doesn't get git push -f'd this time 😅 @JackEllis

@JackEllis
Copy link
Collaborator

@JaneJeon Liking the looks of it. We'll likely merge this in but remove the big button on the repo readme file. Thanks for recovering it!

@JaneJeon
Copy link
Author

@JackEllis hi thanks for replying

The "big button" is what allows people to literally deploy to Heroku with 1 click, so maybe if you don't want it on the top, you can move it down the README? Either way, Heroku buttons do need to be on the README of the repo...

@JaneJeon
Copy link
Author

Aha, I downsized the heroku button so now it fits in with the rest of the badges. I think this fits your criteria?

@JackEllis
Copy link
Collaborator

@JaneJeon That's more along the lines of what we're after, thank you!

@JaneJeon
Copy link
Author

Also please feel free to update the docs on deploying to heroku - 'cause now all you need to do is say "hey look at the deploy to heroku button on the README. Just click it"

@JaneJeon
Copy link
Author

@JackEllis any updates on the merge?

@pull pull bot closed this Oct 22, 2019
@JaneJeon
Copy link
Author

@JackEllis you overwrote my changes again with your README force push... can you just merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants