Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No good error message/validation in GUI when attempting to create a new request with a slash (/) character in the name #1401

Closed
spephton opened this issue Jan 16, 2024 · 4 comments
Labels
bug Something isn't working module-file-naming

Comments

@spephton
Copy link

Attempting to create a request with a slash character (/) in the name fails with an unhelpful error message.

It looks like Bruno attempts to create a file with an illegal character in the file name.

image

Bruno should either transparently escape illegal FS characters or provide a helpful error message in this case, such as "Could not create a request with this name because this name contains illegal characters ({presentIllegalChars})"

Present in 1.6.1 on Windows

@reilee
Copy link

reilee commented Jan 17, 2024

It appears the heading slash can be used in a name (macos) though.

@Its-treason
Copy link
Member

I think this should be fixed with #349. But I want to rewrite, when Anoop has time to review it, the PR because It's pretty old.

@yojeek
Copy link

yojeek commented Jun 4, 2024

it's not validation message what is a problem, forward slashes absolutely must be allowed in request names. It's natural that request name represents some part of url.

@helloanoop
Copy link
Contributor

I have merged the PR #3274 that will now better warnings and prevent file deletion.
This will go out in the upcoming v1.36.0 release scheduled to be released on 4 Dec 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module-file-naming
Projects
None yet
Development

No branches or pull requests

7 participants