Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the cargo warning about unused manifest key #1929

Closed
pmikolajczyk41 opened this issue Oct 3, 2023 · 3 comments · Fixed by #2007
Closed

Get rid of the cargo warning about unused manifest key #1929

pmikolajczyk41 opened this issue Oct 3, 2023 · 3 comments · Fixed by #2007
Assignees
@pmikolajczyk41
Labels
B-enhancement New feature or request dependencies Pull requests that update a dependency file good first issue Good for newcomers

Comments

@pmikolajczyk41
Copy link
Member

When we introduced workspace dependencies (#1835) we had to employ an ugly hack to be able to use parity-scale-codec behind an alias in workspace member crates. Just now a fix for the underlying problem has been published: bkchr/proc-macro-crate#39, and thus soon (once parity-scale-codec incorporates the new version of proc-macro-crate) we can get rid of the hack and finally avoid seeing:

warning: /home/piomiko/Desktop/ink/crates/e2e/Cargo.toml: unused manifest key: dependencies.scale.package
warning: /home/piomiko/Desktop/ink/crates/storage/Cargo.toml: unused manifest key: dependencies.scale.package
warning: /home/piomiko/Desktop/ink/crates/engine/Cargo.toml: unused manifest key: dependencies.scale.package
warning: /home/piomiko/Desktop/ink/crates/ink/Cargo.toml: unused manifest key: dependencies.scale.package
warning: /home/piomiko/Desktop/ink/crates/storage/traits/Cargo.toml: unused manifest key: dependencies.scale.package
warning: /home/piomiko/Desktop/ink/crates/ink/codegen/Cargo.toml: unused manifest key: dependencies.scale.package
warning: /home/piomiko/Desktop/ink/crates/ink/macro/Cargo.toml: unused manifest key: dependencies.scale.package
warning: /home/piomiko/Desktop/ink/crates/env/Cargo.toml: unused manifest key: dependencies.scale.package
warning: /home/piomiko/Desktop/ink/crates/primitives/Cargo.toml: unused manifest key: dependencies.scale.package

during every compilation run.
@pmikolajczyk41 pmikolajczyk41 self-assigned this Oct 3, 2023
@pmikolajczyk41 pmikolajczyk41 added B-enhancement New feature or request good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Oct 3, 2023
@ascjones
Copy link
Collaborator

I've made a PR to update proc-macro-crate in parity-scale-codec: paritytech/parity-scale-codec#535

@pmikolajczyk41 pmikolajczyk41 mentioned this issue Nov 28, 2023
Merged
5 tasks
@pmikolajczyk41
Copy link
Member Author

@ascjones are you able to push next version of parity-scale-codec? the newest one doesn't include your contribution

@ascjones
Copy link
Collaborator

@ascjones are you able to push next version of parity-scale-codec? the newest one doesn't include your contribution

It is slightly tricky since there is apparently a breaking change on master which would require a major release. I have asked to see whether we should do that or juts cherry pick my commit into a new patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmikolajczyk41 pmikolajczyk41

Labels
B-enhancement New feature or request dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get rid of the Cargo hack use-ink/ink
2 participants
@ascjones @pmikolajczyk41