Skip to content

Commit a128994

Browse files
committed
Build supported nginx versions only
This change adds complience with ADR 5 introduced #165. Based on information from: http://nginx.org/en/download.html
1 parent b2e2e44 commit a128994

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

.github/workflows/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ jobs:
3131
- id: supported-nginx-versions
3232
name: Generate nginx
3333
shell: bash
34-
run: | # The "1.17-nginx1-nginx" in here will be changed to "1.17 nginx1 nginx" when calling ./build-http.sh
35-
echo "::set-output name=versions::[\"1.17-nginx1-nginx\", \"1.16\", \"1.15\", \"1.14\"]"
34+
run: | # The "1.19-nginx1-nginx" in here will be changed to "1.19 nginx1 nginx" when calling ./build-http.sh
35+
echo "::set-output name=versions::[\"1.19-nginx1-nginx\", \"1.18\"]"
3636
supported-php-versions:
3737
name: Supported PHP versions
3838
runs-on: ubuntu-latest

Makefile

+3-5
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,14 @@ build-fpm: clean-tags
4545
# Docker HTTP images build matrix ./build-nginx.sh (nginx version) (extra tag)
4646
build-http: BUILDINGIMAGE=http
4747
build-http: clean-tags
48-
./build-http.sh 1.17 nginx1 nginx
49-
./build-http.sh 1.16
50-
./build-http.sh 1.15
51-
./build-http.sh 1.14
48+
./build-http.sh 1.19 nginx1 nginx
49+
./build-http.sh 1.18
5250

5351
# Docker Prometheus Exporter file images build matrix ./build-prometheus-exporter-file.sh (nginx version) (extra tag)
5452
# Adding arbitrary version 1.0 in order to make sure if we break compatibility we have to up it
5553
build-prometheus-exporter-file: BUILDINGIMAGE=prometheus-exporter-file
5654
build-prometheus-exporter-file: clean-tags
57-
./build-prometheus-exporter-file.sh 1.15 prometheus-exporter-file1.0 prometheus-exporter-file1
55+
./build-prometheus-exporter-file.sh 1.18 prometheus-exporter-file1.0 prometheus-exporter-file1
5856

5957
.NOTPARALLEL: clean-tags
6058
clean-tags:

test/e2e/test_nginx_entrypoint.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def test_nginx_sigterm_handling(host, container):
1515

1616
logs = host.run('docker logs {}'.format(container))
1717

18-
assert u'signal 15 (SIGTERM) received, exiting' in logs.stderr
18+
assert u'signal 3 (SIGQUIT) received, shutting down' in logs.stderr
1919
assert u'exit' in logs.stderr
2020

2121

0 commit comments

Comments
 (0)