feat: add TextFlag #2055
Open
feat: add TextFlag #2055
+211
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added `TextFlag` which supports setting values for types that satisfies the `encoding.TextMarshaller` and `encoding.TextUnmarshaller` which is very handy when you want to set log levels or string-like types that satifies the interfaces. Fixes: urfave#2051 Signed-off-by: Tobias Dahlberg <[email protected]>
Signed-off-by: Eng Zer Jun <[email protected]>
Juneezee
reviewed
Feb 11, 2025
| return err | ||
| } | ||
|
|
||
| if slices.Compare(text, []byte("INFO")) != 0 { |
There was a problem hiding this comment.
Suggested change
| if slices.Compare(text, []byte("INFO")) != 0 { | |
| if !slices.Equal(text, []byte("INFO")) { |
Comment on lines
+88
to
+104
| if err := tt.flag.Apply(set); err != nil { | ||
| t.Fatalf("Apply(%v) failed: %v", tt.args, err) | ||
| } | ||
|
|
||
| err := set.Parse(tt.args) | ||
| if (err != nil) != tt.wantErr { | ||
| t.Errorf("Parse() error = %v, wantErr %v", err, tt.wantErr) | ||
|
|
||
| return | ||
| } else if (err != nil) == tt.wantErr { | ||
| // Expected error. | ||
| return | ||
| } | ||
|
|
||
| if got := tt.flag.GetValue(); got != tt.want { | ||
| t.Errorf("Value = %v, want %v", got, tt.want) | ||
| } |
There was a problem hiding this comment.
Use the testify package for assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextFlagwhich supports setting values for types that satisfies bothencoding.TextMarshallerandencoding.TextUnmarshallerwhich is very handy when you want to set log levels or string-like types that satisfies the interfaces.Fixes: #2051
What type of PR is this?
What this PR does / why we need it:
Making it easier to set types that satisfies
encoding.TextMarshallerandencoding.TextUnmarshallersuch aslog/slog.LogLevelVar, using flags as see in the standard library'sflag.Which issue(s) this PR fixes:
Fixes #2051
Release Notes