Skip to content

Commit ff292b2

Browse files
committed
fix: parallel running - improve clonning of global flags
1 parent 53ab291 commit ff292b2

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

command_setup.go

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -83,14 +83,8 @@ func (cmd *Command) setupDefaults(osArgs []string) {
8383
if !cmd.globaVersionFlagAdded {
8484
var localVersionFlag Flag
8585
if globalVersionFlag, ok := VersionFlag.(*BoolFlag); ok {
86-
// clone VersionFlag
87-
localVersionFlag = &BoolFlag{
88-
Name: globalVersionFlag.Name,
89-
Aliases: globalVersionFlag.Aliases,
90-
Usage: globalVersionFlag.Usage,
91-
HideDefault: globalVersionFlag.HideDefault,
92-
Local: globalVersionFlag.Local,
93-
}
86+
flag := *globalVersionFlag
87+
localVersionFlag = &flag
9488
} else {
9589
localVersionFlag = VersionFlag
9690
}
@@ -212,14 +206,8 @@ func (cmd *Command) ensureHelp() {
212206
if !cmd.globaHelpFlagAdded {
213207
var localHelpFlag Flag
214208
if globalHelpFlag, ok := HelpFlag.(*BoolFlag); ok {
215-
// clone HelpFlag
216-
localHelpFlag = &BoolFlag{
217-
Name: globalHelpFlag.Name,
218-
Aliases: globalHelpFlag.Aliases,
219-
Usage: globalHelpFlag.Usage,
220-
HideDefault: globalHelpFlag.HideDefault,
221-
Local: globalHelpFlag.Local,
222-
}
209+
flag := *globalHelpFlag
210+
localHelpFlag = &flag
223211
} else {
224212
localHelpFlag = HelpFlag
225213
}

0 commit comments

Comments
 (0)