Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fulfill ValueSource interface for urfave/cli/v3 integration #5

Closed
meatballhat opened this issue Jun 23, 2023 · 0 comments · Fixed by #6
Closed

Fulfill ValueSource interface for urfave/cli/v3 integration #5

meatballhat opened this issue Jun 23, 2023 · 0 comments · Fixed by #6
Assignees
@meatballhat
Labels
enhancement New feature or request

Comments

@meatballhat
Copy link
Member

meatballhat commented Jun 23, 2023 •
edited
Loading

The github.com/urfave/cli/v3 API includes a ValueSource interface for flag-level value loading with in-library implementations for environment variables and flat files. The functions here that return an InputSourceContext interface should be replaced by convenience functions like those in the main library:

  • NewJSONSource.* ➡️ JSON(...)
  • NewTomlSource.* ➡️ TOML(...)
  • NewYamlSource.* ➡️ YAML(...)
@meatballhat meatballhat added the enhancement New feature or request label Jun 23, 2023
@meatballhat meatballhat self-assigned this Jun 23, 2023
@meatballhat meatballhat mentioned this issue Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meatballhat meatballhat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate with urfave/cli/v3 APIs urfave/cli-altsrc
1 participant
@meatballhat