Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite rlocation function in fish #6

Open
Matthew-Benson opened this issue May 7, 2024 · 0 comments
Open

Rewrite rlocation function in fish #6

Matthew-Benson opened this issue May 7, 2024 · 0 comments

Comments

@Matthew-Benson
Copy link
Collaborator

Today, we package a standalone bash script for rlocation support for runfiles.

This also leaves us with a weird, hidden dependency on bash, which could cause issues stemming from system bash not being hermetic.

Unfortunately, the rlocation function we're getting from bash rules actually doesn't seem to work right in some cases with bzlmod. We should instead copy the logic from the Go library runfiles in our implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant