Fix #159 singleton abstract methods #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2023
ivojawer
approved these changes
Sep 15, 2023
src/validator.ts
Outdated
|
|
||
| const allParents = (module: Module) => | ||
| module.supertypes.map(supertype => supertype.reference.target).flatMap(supertype => supertype?.hierarchy ?? []) | ||
|
|
||
| const inheritsCustom = (module: Module) => notEmpty(allParents(module).filter(element => element.name === baseClass)) |
There was a problem hiding this comment.
Mmm... está mal esta definición jajaja, es !==. Es decir hay que filtrar a Object de los parents, y ver que la lista no sea vacía.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bueno, esto requiere varias partes: acá viene la parte del validador, para separarlo en otra tipificación.
De paso, creé una función para determinar si una clase hereda de otra custom (que no sea Object).
Para que pase el CI necesitamos mergear primero los tests de wollok-language que voy a crear ahora y van a estar asociados a este PR.