Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archivos con guiones #247

Closed
ivojawer opened this issue Jun 6, 2024 · 0 comments · Fixed by #254
Closed

Archivos con guiones #247

ivojawer opened this issue Jun 6, 2024 · 0 comments · Fixed by #254

Comments

@ivojawer
Copy link
Contributor

ivojawer commented Jun 6, 2024

Ahora tenemos "banneados" un monton de caracteres especiales para los nombres archivos, muchos de estos se definieron aca: #239 (comment).

El - lo estamos validando para que no rompa los imports (aca un PR relacionado: uqbar-project/wollok-language#187) pero si cambiamos el parser podriamos aceptarlos!

Ademas habria que cambiar la validation

export const shouldNotUseSpecialCharactersInName = error<Package>(node =>
!node.fileName ||
node.fileName.match(/([A-Za-z._/\d])/g)!.length === node.fileName.length
&& node.fileName.match(/\./g)!.length === 1
, valuesForFileName,
sourceMapForNodeName)

y cambiar el archivo invalido de lang con - uqbar-project/wollok-language#187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant