Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lanzar excepción si al buscar una variable dentro de un módulo no se encuentra #227

Open
PalumboN opened this issue Mar 20, 2024 · 0 comments
Open

Lanzar excepción si al buscar una variable dentro de un módulo no se encuentra #227

PalumboN opened this issue Mar 20, 2024 · 0 comments
Labels
component: model Base model priority: low A nice to have, or not so important issue

Comments

@PalumboN
Copy link
Contributor

PalumboN commented Mar 20, 2024 •
edited by fdodino
Loading 

isConstant(localName: string): boolean {
    return this.module.lookupField(localName)?.isConstant ?? false // TODO: instead of false we should throw an error

Agregar tests y probar ts-cli y lsp-ide para ver que no afecte nada

Originally posted by @PalumboN in #219 (comment)
@fdodino fdodino changed the title Quedo un TODO para un issue. Lanzar excepción si al buscar una variable dentro de un módulo no se encuentra Apr 19, 2024
@fdodino fdodino added component: model Base model good first issue Good for newcomers priority: low A nice to have, or not so important issue labels Apr 19, 2024
@ivojawer ivojawer removed the good first issue Good for newcomers label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: model Base model priority: low A nice to have, or not so important issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PalumboN @fdodino @ivojawer