Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nombre de archivo con caracteres inválidos en Windows #186

Closed
mbertogliati opened this issue May 30, 2024 · 2 comments · Fixed by #187
Closed

Nombre de archivo con caracteres inválidos en Windows #186

mbertogliati opened this issue May 30, 2024 · 2 comments · Fixed by #187
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mbertogliati
Copy link

mbertogliati commented May 30, 2024

El nombre del archivo -$!"·$%&( )=|@¢∞¬÷“≠'?.wlk contiene los caracteres "|? los cuales no son aceptados en Windows.

No lo son ninguno de los siguientes: /\:*"?<>|

Esto lanza un error al clonar el repositorio y el archivo no se copia. Además, rompe con otros repositorios que utilizan este y tienen automatizado el proceso de clonación, como wollok-cli.

Cloning into 'wollok-language'...
remote: Enumerating objects: 4009, done.
remote: Counting objects: 100% (1690/1690), done.
remote: Compressing objects: 100% (965/965), done.
remote: Total 4009 (delta 825), reused 1397 (delta 650), pack-reused 2319
Receiving objects: 100% (4009/4009), 838.08 KiB | 3.09 MiB/s, done.
Resolving deltas: 100% (2155/2155), done.
error: unable to create file test/validations/-$!"·$%&( )=|@¢∞¬÷“≠'?.wlk: Invalid argument
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'```
@PalumboN PalumboN added bug Something isn't working good first issue Good for newcomers labels Jun 1, 2024
@PalumboN
Copy link
Contributor

PalumboN commented Jun 1, 2024

Buuuu presentía que algo así iba a pasar con ese nombre choto jajaja. Se nota que los principales desarrolladores de Wollok no usamos Windows :P

Propongo renombrarlo simplemente a invalid-name.wlk (o si queremos aceptar -, que no veo razones fuertes para no hacerlo) $invalid$name$.wlk

@ivojawer
Copy link
Contributor

ivojawer commented Jun 6, 2024

Hay una razon por la cual no aceptamos los guines, que es por los imports (uqbar-project/wollok-ts#239 (comment) aca dodine tiro la posta sobre todos estos caracteres 😎)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants