Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoherent behaviour with preview (detailRenderer) on simple/double click #85

Open
ylacaute opened this issue Dec 24, 2019 · 0 comments

Comments

@ylacaute
Copy link

ylacaute commented Dec 24, 2019

Bug: When you are navigating in the tree with simple click, the renderDetails function does not always return the selected file. When you double click, the last renderDetails return the good file (but spams events).

Version: 1.6.0 and master branch.

Expected behaviour: the renderDetails has always the selected file, folder or file, exactly as onSelectFile prop, on simple or double click.

I tryed to write a PR but I am afraid to refactor too many things. I don't understand why you dissociate selection and preview behaviour, with simple and double click. Anyway the result is very confusing for the final user.

I think it would be better to active preview on each click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant