Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): add english-only build #41

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

henrymyers
Copy link
Contributor

Description

As mentioned by @jeetiss in issue 786, the effects tab doesn't work when importing the english-only version of uploadcare-widget (because they import and patch different bundles).

This PR does the following:

  • Generate an english-only bundle that imports the correct uploadcare.lang.en.js bundle. (ESM and UMD)
  • Generate a minified english-only bundle that imports the correct uploadcare.lang.en.min.js bundle. (UMD)
  • Update the existing minified bundle so that it imports the correct uploadcare.min.js bundle. (UMD)

I also did the equivalent for the @uploadcare/react-widget repo. See PR 252.

Checklist

@nd0ut nd0ut merged commit 34c4507 into uploadcare:master Mar 31, 2021
@nd0ut
Copy link
Member

nd0ut commented Mar 31, 2021

@henrymyers Thanks! I'll release it soon. 🚀

@henrymyers henrymyers deleted the en-min-builds branch March 31, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants