Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call previewUrlCallback before rendering crop effect #40

Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix: call previewUrlCallback before rendering crop effect #40

merged 1 commit into from
Jun 2, 2020

Conversation

jeetiss
Copy link
Contributor

@jeetiss jeetiss commented Jun 1, 2020

Description

call previewUrlCallback before rendering crop effect

report:

While implementing authenticate url i found that Crop feature is not working with authentication url. Other effects like rotate, mirror working properly.
I used UPLOADCARE_PREVIEW_URL_CALLBACK method
In case of crop, I found that url is going with coming in above defined callback function.

@jeetiss jeetiss requested a review from nd0ut June 1, 2020 14:01
@nd0ut
Copy link
Member

nd0ut commented Jun 1, 2020

Please, update changelog
🍰

@jeetiss jeetiss merged commit 5a1c520 into master Jun 2, 2020
@jeetiss jeetiss deleted the fix-preview-url-callback branch June 2, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nd0ut nd0ut nd0ut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeetiss @nd0ut