Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear img src before update it #24

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Clear img src before update it #24

merged 1 commit into from
Jun 22, 2018

Conversation

nd0ut
Copy link
Member

@nd0ut nd0ut commented Jun 21, 2018

Safari do not fire onload event when Image src is updated with the same url.
So we clear src property before assign a new one and Safari start working as expected.

@nd0ut nd0ut requested review from Zmoki and bautrukevich June 22, 2018 08:15
@nd0ut nd0ut merged commit 889fba8 into master Jun 22, 2018
@nd0ut nd0ut deleted the fix/safari-crop branch June 22, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bautrukevich bautrukevich bautrukevich approved these changes

@Zmoki Zmoki Zmoki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nd0ut @Zmoki @bautrukevich